spotless icon indicating copy to clipboard operation
spotless copied to clipboard
verified publisher icon diffplug

Make all steps with JarState serializable

Open Goooler opened this issue 2 years ago • 1 comments

Refs https://github.com/diffplug/spotless/issues/1274#issuecomment-1839694669.

Goooler avatar Feb 13 '24 14:02 Goooler

  • JacksonJsonStepTest is failing because the original value is not .equals to the roundtripped value. I'm not exactly sure why, but it might be related to map ordering in LinkedHashMap. I would try TreeMap, and then resort to stepping through the debugger to see where it's different.
    • https://github.com/diffplug/spotless/actions/runs/7888529718/job/21526323653?pr=2039#step:6:437
  • FreskMarkExtensionTest is failing too, not sure why
    • https://github.com/diffplug/spotless/actions/runs/7888529718/job/21526323653?pr=2039#step:6:575

nedtwigg avatar Feb 13 '24 16:02 nedtwigg

Flaky test on Java 11?

https://scans.gradle.com/s/tqpg7bx3x5v4m/tests/overview?outcome=FAILED

Goooler avatar Apr 03 '24 07:04 Goooler

Huzzah!

nedtwigg avatar Apr 03 '24 16:04 nedtwigg