herddb icon indicating copy to clipboard operation
herddb copied to clipboard

StaticClientSideMetadataProvider doesn't export the real nodeId

Open diegosalvi opened this issue 7 years ago • 2 comments

Bug report

Class StaticClientSideMetadataProvider report a nodeId as 'host:port' but it should be the node from nodeId file (like 'mucca', 'cavallo'....), otherwise other facilities using it could fail

diegosalvi avatar Apr 23 '19 10:04 diegosalvi

I am leaning toward closing this ticket as won't fix.

StaticClientSideMetadataProvider has its own conventions and it is working properly. We could add a new constructor and enhance the URL for connection in a way that the user can pass the nodeId.

Alternatively we can make it that it does not report host:port as nodeId but a know constant like 'here' or 'static' or 'unknown' , to make it clear that this provider does not handle this information

eolivelli avatar Apr 24 '19 05:04 eolivelli

+1 to return a "local" or "here" or some well defined constant string and document it on interface

diegosalvi avatar May 06 '19 09:05 diegosalvi