react-pdf-site icon indicating copy to clipboard operation
react-pdf-site copied to clipboard

Fix: Resume Repl Example

Open bdkopen opened this issue 1 year ago • 6 comments

  • Update the Resume repl example to use the working example originally provided in the react-pdf repo.

Deployment preview: https://react-pdf-git-fork-bdkopen-fix-resume-example-diegomuracciole.vercel.app//repl?example=resume

Fixes issue: #138

bdkopen avatar Oct 11 '24 02:10 bdkopen

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-pdf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 3:52am
site-7bsx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 3:52am

vercel[bot] avatar Oct 11 '24 02:10 vercel[bot]

Doc looks broken to me in url 😕

diegomura avatar Nov 17 '24 01:11 diegomura

Sorry for the delay here, @diegomura! Ready for re-review.

I fixed the text overflowing and caught a few other spelling issues. Also made a few more Star Wars trivia corrections.

bdkopen avatar Jan 11 '25 02:01 bdkopen

Screenshot 2025-01-11 at 12 00 15 AM

Header paddings look odd to me. And also right alignment on the resume entries

diegomura avatar Jan 11 '25 03:01 diegomura

@diegomura ready to go again.

I realized that this template was originally from the react-pdf repo (source). Rather than trying to fix all the styling here to try and make it look alright, I think it makes a lot more sense to just pull that working example directly in here.

I consolidated the multiple files into this one. The only modification was renaming the component styles variables to more specific ones like headerStyles.

Since the original example renders three pages with different @media layouts, this example will now demonstrate that too!

You can compare the rendered output to these snapshots (here, here, and here).

bdkopen avatar Jan 11 '25 03:01 bdkopen

@diegomura just a friendly reminder. Let me know if this needs any further adjustments.

bdkopen avatar May 15 '25 14:05 bdkopen