CleanLinks icon indicating copy to clipboard operation
CleanLinks copied to clipboard
verified publisher icon diegocr

CleanLinks does not work with RequestPolicy

Open Dupond opened this issue 10 years ago • 5 comments

Hello,

First of all thank you for this great open-source addon !

I use the RequestPolicy addon for Firefox too, and it seems that CleanLinks is not compatible with it : fore example, a Google news link (https://news.google.com/news/url?sa=t&fd=R&ct2=fr&usg=AFQjCNFt6NBNfpC1GAkQ0YuZovrIKC2lJA&clid=c3a7d30bb8a4878e06b80cf16b898331&cid=52779336040946&ei=mSIqVaH-CoHNiQaGpoCABQ&url=http://www.leparisien.fr/psg-foot-paris-saint-germain/en-images-bastia-psg-0-4-la-coupe-de-la-ligue-en-aperitif-11-04-2015-4684807.php) displays a "Moved Temporarily" page when clicked, asking for allowing to redirect or not.

My impression is that RequestPolicy works BEFORE CleanLinks can convert the link. However, with an addon like "Remove Google tracking" (available on AMO), the link is converted correctly and I'm not asked for allowing to redirect.

I hope I am clear (sorry for my pretty poor english), Best regards, Dupond

Dupond avatar Apr 12 '15 08:04 Dupond

I am using the new request policy beta, and that URL works fine for me.

https://github.com/RequestPolicyContinued/requestpolicy

AeliusSaionji avatar Apr 28 '15 03:04 AeliusSaionji

Well, it doesn't for me. I've tested it with BOTH the old RequestPolicy version available on AMO, AND RequestPolicyContinued. The result is the same : a page is displayed, with a "Moved temporarily" link.

Dupond avatar Apr 28 '15 13:04 Dupond

I've investigated further, and I've found why we have two different behaviors here : my RequestPolicy is set to "forbid requests by default" as a default policy. I think CleanLinks should sanitize the URL before RequestPolicy forbids the request. Is this doable ? Those two addons should be prioritized.

Dupond avatar May 22 '15 05:05 Dupond

Forbid by default is ideally the way you're supposed to use RequestPolicy, and it is the way I have it configured.

AeliusSaionji avatar May 22 '15 07:05 AeliusSaionji

So this is really strange. I've tested again : all addons disabled, except Clean Links 2.7 and RequestPolicy 1.0beta9.2 (with "Forbid requests by default", "Allow destinations that belong to the same organization as the origin webpage" and "Allow requests that are needed for other extensions to work properly" checked, all other subscriptions unchecked).

Would you have *.google.com authorized, by any chance ?

Dupond avatar May 22 '15 15:05 Dupond