ui icon indicating copy to clipboard operation
ui copied to clipboard

chore: update modal accessibility and translation

Open Chisomchima opened this issue 2 years ago • 2 comments

Implements Jira Ticket


Description

Implements Jira Ticket by updating the Modal CloseButton component to update title and aria-label attributes, as well as the close onClick of the escape button


Known issues

  • [ ] None

Chisomchima avatar Mar 20 '24 11:03 Chisomchima

🚀 Deployed on https://pr-1465--dhis2-ui.netlify.app

dhis2-bot avatar Mar 20 '24 11:03 dhis2-bot

4 failed tests on run #3393 ↗︎

4 580 0 0 Flakiness 0

Details:

chore: update modal accessibility and translation
Project: ui Commit: 8f7b8b84c3
Status: Failed Duration: 06:47 💡
Started: May 24, 2024 12:19 PM Ended: May 24, 2024 12:26 PM
Failed  components/sharing-dialog/src/features/add-entity.feature • 4 failed tests • e2e

View Output

Test Artifacts
Allows users to add entities to the allowed list > User can give user view only access (example #1) Screenshots
Allows users to add entities to the allowed list > User can give user view and edit access (example #2) Screenshots
Allows users to add entities to the allowed list > User can give group view only access (example #3) Screenshots
Allows users to add entities to the allowed list > User can give group view and edit access (example #4) Screenshots

Review all test suite changes for PR #1465 ↗︎

cypress[bot] avatar Mar 20 '24 11:03 cypress[bot]

:tada: This PR is included in version 9.8.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

dhis2-bot avatar Jun 19 '24 09:06 dhis2-bot