dgraph chore(deps): bump github.com/spf13/cast from 1.3.1 to 1.7.0

Bumps github.com/spf13/cast from 1.3.1 to 1.7.0.

Release notes

Sourced from github.com/spf13/cast's releases.

v1.7.0

What's Changed

Misc improvements by @bep in spf13/cast#221

Full Changelog: https://github.com/spf13/cast/compare/v1.6.0...v1.7.0

v1.6.0

What's Changed

Bump actions/setup-go from 3 to 4 by @dependabot in spf13/cast#180

Bump github.com/frankban/quicktest from 1.14.4 to 1.14.5 by @dependabot in spf13/cast#185

Updates by @sagikazarmark in spf13/cast#190

deps/update20231128 by @bep in spf13/cast#205

Full Changelog: https://github.com/spf13/cast/compare/v1.5.1...v1.6.0

v1.5.1

What's Changed

Correction of hugo URL error by @qwxingzhe in spf13/cast#164

Improve CI by @sagikazarmark in spf13/cast#167

Bump github.com/frankban/quicktest from 1.14.3 to 1.14.4 by @dependabot in spf13/cast#168

Add more integer to boolean conversions by @yveshield in spf13/cast#153

Pull the 2006-01-02 layout to the top when checking by @bep in spf13/cast#187

New Contributors

@qwxingzhe made their first contribution in spf13/cast#164

@sagikazarmark made their first contribution in spf13/cast#167

@dependabot made their first contribution in spf13/cast#168

@yveshield made their first contribution in spf13/cast#153

Full Changelog: https://github.com/spf13/cast/compare/v1.5.0...v1.5.1

v1.5.0

Add support for json.Number

Enable integer and float conversion of time.Weekday and time.Month values

Allow nil in ToFloat* (which gets it in line with the rest)

Trim trailing zero decimals from string numbers, e.g. 10.0 before any int parsing.

Remove some test duplication

Replace testify with quicktest

v1.4.1

No release notes provided.

Add ToTimeInDefaultLocation/E

No release notes provided.

Commits

6e0c3ab Support some commonly used Float64 interfaces
6c5f3fc github: Bump versions
48ddde5 Bump Go version in go.mod to 1.19
b09a6f8 deps: update to github.com/frankban/quicktest v1.14.6
268227c github: Replace the test workflow with the one used in Afero
e9ba3ce Merge pull request #190 from spf13/updates
9d37e3a ci: fix dependabot config
a441ac7 ci: pin actions versions, fix checkout order
9c5e91d docs: update badges
c49a664 ci: rename ci.yml to ci.yaml
Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Aug 24 '24 20:08 dependabot[bot]

@dependabot rebase

Aug 25 '24 11:08 ryanfoxtyler

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

Aug 25 '24 11:08 dependabot[bot]

@dependabot recreate

Aug 25 '24 11:08 ryanfoxtyler

@ryanfoxtyler This PR & #9143 both have an issue causing a integration2 tests to fail. I spent some time looking into it when I was working on the PR #9115. It is pretty strange that an upgrade such as this causing our bulk loader to behave different. I couldn't get to the bottom of it then.

Aug 29 '24 11:08 mangalaman93

@mangalaman93 agreed it's odd that these dependency bumps are failing consistently on this test. These test suites are still flaky at times, so perhaps this change is moving it from flaky to always failing?

Seeing this error on TestBulkLoaderNoDqlSchema

Error communicating with dgraph zero, retrying: rpc error: code = Unknown desc = Assigning IDs is only allowed on leader.Error communicating with dgraph zero, retrying: rpc error: code = Unknown desc = Assigning IDs is only allowed on leader.Error communicating with dgraph zero, retrying: rpc error: code = Unknown desc = Assigning IDs is only allowed on leader.

We've seen this before, right?

Aug 29 '24 12:08 ryanfoxtyler

@mangalaman93 agreed it's odd that these dependency bumps are failing consistently on this test. These test suites are still flaky at times, so perhaps this change is moving it from flaky to always failing?

Seeing this error on TestBulkLoaderNoDqlSchema

Error communicating with dgraph zero, retrying: rpc error: code = Unknown desc = Assigning IDs is only allowed on leader.Error communicating with dgraph zero, retrying: rpc error: code = Unknown desc = Assigning IDs is only allowed on leader.Error communicating with dgraph zero, retrying: rpc error: code = Unknown desc = Assigning IDs is only allowed on leader.

We've seen this before, right?

Aug 29 '24 12:08 ryanfoxtyler

the error you posted is just a transient error, not a fatal error. We should be more clear about that in the logs. The test suites are a lot less flaky now from before after we fixed the issue with tcp6. I completely agree that we need to do more and we will keep working on that as we observe them.

For now, I will look into this issue and figure out what is going on. Most likely a dep of this upgrade is affecting something. I will post my conclusions and hopefully it reduces the flakyness too.

Aug 29 '24 15:08 mangalaman93

@shivaji-dgraph and I were looking into this and we found out a bug in the cast library. It has already been pointed out in this issue https://github.com/spf13/cast/issues/211. I see a commit made last month but this small library has 52 open issues and 44 open PRs that have not been looked at. There are multiple PRs such as https://github.com/spf13/cast/pull/155 and https://github.com/spf13/cast/pull/213 that try to fix this issue but they have not been merged. Viper library also has this issue open https://github.com/spf13/viper/issues/1474 for two years but nothing yet. Same applies for #9143.

This affects Dgraph because we use math.MaxUint64 as our default value that viper is unable to parse due to this bug.

Sep 05 '24 11:09 mangalaman93

OK, I won't notify you about version 1.x.x again, unless you re-open this PR.

Sep 05 '24 11:09 dependabot[bot]