Doug Rabson
Doug Rabson
Looking at #4645 and comparing my container_create_freebsd.go with container_create_linux.go, it seems clear that at least for mounts, we will need some parts to be linux only - anything involving sysfs...
Other platform-specific things being added to the OCI spec include the apparmor profile, blockio and other resources, cgroups path, capabilities and anything else which touches specgen.Config.Linux
> I think I'd prefer to share code where possible. Even if the readibility suffers, it will reduce the liklihood we miss patches to one or the other The approach...
I re-implemented this to keep as much of the code for container creation shared between Linux and FreeBSD. I kept the history fairly detailed to make it easier to see...
Note: this iteration disables timezone support for FreeBSD - this can be removed if we update the vendor of github.com/containers/common to v0.58 but perhaps that should happen in a separate...
> @dfr, you might have to rebase this against `main` as there have been changes that will affect your work here. I just rebased and updated the PR, thanks!
> @dfr, could you rebase on top of the main branch to pick the `container/common` changes? Thanks for updating the vendor of c/common - I rebased this PR and it...
Sorry about that - too much multitasking over the last few months pushed this back a bit. I should be able to get back to it soon.
/retest-required
> @dfr could you rebase this PR on top of the main branch? It looks like CI is green now. @cri-o/cri-o-maintainers PTAL I just rebased and pushed so hopefully the...