vessel icon indicating copy to clipboard operation
vessel copied to clipboard

Support multiple packages in one repository.

Open matthewhammer opened this issue 4 years ago • 4 comments

#37

matthewhammer avatar Nov 09 '21 18:11 matthewhammer

This PR is still a draft, but it may be ready enough for initial feedback from @kritzcreek, for an initial sanity check. Going to change to "ready for review", even though there is probably more to do before reviewing fully.

matthewhammer avatar Nov 09 '21 19:11 matthewhammer

Hey, I agree this is a desirable feature. I'm a bit worried about breaking all the package-sets we've put out there so far. Maybe we could make the parameter non-optional, but continue to try and parse the old format for a while? While emitting a warning that we defaulted the path configuration to src for all the packages that were missing it?

Just a suggestion, if you think it's better to rip off the bandaid, I'm happy to approve.

kritzcreek avatar Nov 15 '21 08:11 kritzcreek

Maybe we could make the parameter non-optional, but continue to try and parse the old format for a while? While emitting a warning that we defaulted the path configuration to src for all the packages that were missing it?

Okay, I like that idea, and concurrently I had begun to sour on the optional-ness of path, and wanted to also make it mandatory, where people would write "src" to get the current behavior. This evolution path seems natural and good to me! Thanks for taking a look!

matthewhammer avatar Nov 17 '21 18:11 matthewhammer

Hi @matthewhammer, any plans to pick this up again? Do you need a hand?

q-uint avatar Jan 15 '22 11:01 q-uint