sdk icon indicating copy to clipboard operation
sdk copied to clipboard

refactor: change pull-type canisters into custom-type

Open ericswanson-dfinity opened this issue 1 year ago • 0 comments

Description

This is a proof-of-concept, deleting both PullCanisterInfo and PullBuilder.

This is meant as a first step in moving toward an approach where canister properties aren't specific to a particular "type" of canister (though some properties may be mutually exclusive).

Note the dummy values when constructing CanisterTypeProperties::Custom.

Compare to https://github.com/dfinity/sdk/pull/3679

How Has This Been Tested?

refactor covered by e2e

Checklist:

  • [ ] The title of this PR complies with Conventional Commits.
  • [ ] I have edited the CHANGELOG accordingly.
  • [ ] I have made corresponding changes to the documentation.

ericswanson-dfinity avatar Mar 28 '24 15:03 ericswanson-dfinity