quill icon indicating copy to clipboard operation
quill copied to clipboard

feat: second round of ledger commands

Open adamspofford-dfinity opened this issue 2 years ago • 0 comments

This PR adds support for more Ledger operations, introduced in v2.4 of the ICP app. Many SNS neuron operations remain unsupported, but importantly neurons can now be staked and the full range of NNS neuron functionality is now supported.

This required two changes to the default neuron-staking functionality:

  • The transfers are now made with the ICRC-1 API.
  • The claim-or-refresh call is now unsigned - it seemingly can be made by any user, not just the one that owns the neurons, and this is required for the Ledger functionality as Ledger intentionally rejects claim-or-refresh messages since it does not need to be sent them. The NNS frontend app does this as well.

adamspofford-dfinity avatar Nov 08 '23 22:11 adamspofford-dfinity