nns-dapp icon indicating copy to clipboard operation
nns-dapp copied to clipboard

Update proposal rendering dependencies + fixes

Open dskloetd opened this issue 1 year ago • 0 comments

Motivation

We have a job to make these changes automatically, but there were breaking changes so this PR replaces the automatic PR.

Breaking changes:

  1. UpdateElectedReplicaVersionsPayload was renamed to ReviseElectedGuestosVersionsPayload
  2. UpdateSubnetReplicaVersionPayload to DeployGuestosToAllSubnetNodesPayload
  3. Variant ApiBoundaryNodes was added to FirewallRulesScope

Changes

  1. Ran scripts/proposals/did2rs to make automatic changes to various api.rs files.
  2. Manually apply type name changes to def.rs and lib.rs.

Tests

  1. Add a test for propose-to-add-firewall-rules which had a breaking change by having a new variant added to FirewallRulesScope.
  2. The proposal types that were renamed (nns functions 11 and 38) were already covered by tests.

Todos

  • [x] Add entry to changelog (if necessary).

dskloetd avatar May 10 '24 20:05 dskloetd