interface-spec icon indicating copy to clipboard operation
interface-spec copied to clipboard
verified publisher icon dfinity

[FINAL] feat: wasm_memory_persistence option for canister upgrades

Open mraszyk opened this issue 1 year ago • 4 comments

This PR adds an option (called wasm_memory_persistence) for canister upgrades. If this option is set, then the WebAssembly memory of the old canister is preserved across the upgrade.

mraszyk avatar Mar 12 '24 10:03 mraszyk

@luc-blaeser Is it important to distinguish between "WebAssembly state" and "WebAssembly memory state"? I saw you suggested inserting "memory" and I wonder why you made the suggestion.

mraszyk avatar Mar 12 '24 16:03 mraszyk

@luc-blaeser Is it important to distinguish between "WebAssembly state" and "WebAssembly memory state"? I saw you suggested inserting "memory" and I wonder why you made the suggestion.

It is not important. I only thought that the binary will be replaced (with its contained passive data segments).

luc-blaeser avatar Mar 12 '24 16:03 luc-blaeser

Redirecting the review to @eust-dfinity and @alexandru-uta

ulan avatar Mar 13 '24 09:03 ulan