ic icon indicating copy to clipboard operation
ic copied to clipboard

feat: [MR-592] Define and enforce callback limits

Open alin-at-dfinity opened this issue 1 year ago • 1 comments

Define a subnet-wide soft cap on callbacks; and a per-canister guaranteed callback quota; and enforce them when outgoing requests are being enqueued.

alin-at-dfinity avatar Oct 04 '24 08:10 alin-at-dfinity

This is an exceedingly rough attempt at enforcing callback limits. I spent a lot of time trying to figure out what was the most appropriate way of passing this available count or that limit all the way down into SandboxSafeSystemState, but I may not have gotten it perfectly right.

Edit (2024.11.07): In the meantime, the change is quite polished. Feedback on my choices for passing down the callback limit into SandboxSafeSystemState is still appreciated, though.

alin-at-dfinity avatar Oct 04 '24 08:10 alin-at-dfinity

We no not want reaching this cap to result in canisters being unable to make any calls at all, ...

Typo in the 3rd paragraph of the description.

stiegerc avatar Nov 15 '24 10:11 stiegerc