candid icon indicating copy to clipboard operation
candid copied to clipboard

Fix: candiff accepts unary tuples as default

Open matthewhammer opened this issue 5 years ago • 1 comments

The candid values saved bydfx via didc were not accepted by candiff to diff, because of some mismatch of input being a tuple versus a (bare) un-tupled value.

This PR fixes this issue by changing the default behavior:

  • introduces an unimplemented flag for accepted bare values (the old default).
  • the new default matches what didc produces.

We can implement the old behavior when it blocks something. The missing code path traps as unimplemented.

matthewhammer avatar Aug 26 '20 19:08 matthewhammer

Thanks. Will fix the failing tests (tomorrow) before merging, obviously. I forgot to run cargo test locally first.

matthewhammer avatar Aug 26 '20 23:08 matthewhammer