agent-js icon indicating copy to clipboard operation
agent-js copied to clipboard
verified publisher icon dfinity

Evaluate AssetManager Performance

Open krpeacock opened this issue 3 years ago • 1 comments

Describe the Issue We reduced the upload size in #603 in order to get the tests to pass. Because large uploads will be a common use case for this tool, we should evaluate and benchmark various sizes of uploads in e2e tests in a browser and nodejs context

Instead of random bytes, we can also use some pre-existing assets with various file sizes - maybe a single image exported at different resolutions would be straightforward

Acceptance Criteria Nodejs

  • [ ] 2mb(small upload)
  • [ ] 3mb(chunked upload)
  • [ ] 10mb(moderate upload) Browser
  • [ ] 2mb(small upload)
  • [ ] 3mb(chunked upload)
  • [ ] 10mb(moderate upload)

krpeacock avatar Oct 05 '22 23:10 krpeacock

Larger asset tests were timing out due to #638. PR to increase asset sizes back to 1MB and 3MB: https://github.com/dfinity/agent-js/pull/639

I'll make another PR afterwards to add 10MB tests and browser tests. I would make a 1MB test instead of 2MB test so it doesn't get chunked (3MB and 10MB will).

sea-snake avatar Oct 06 '22 00:10 sea-snake