devtron icon indicating copy to clipboard operation
devtron copied to clipboard

Bug: SSO Login Service configuration is misaligned and prevents saving

Open woopla opened this issue 1 year ago • 19 comments

📜 Description

I just installed v1.0.0 using the Helm chart, and I cannot configure LDAP access. It seems to be because the YAML fields are misaligned:

Image

In all the examples I could see on your site, all the editable part is indented to be part of config.

👟 Reproduction steps

  1. Go to Global Configurations -> Authorization -> Login Services
  2. Edit the LDAP config
  3. Click on "Save" (even using the default config)

👍 Expected behavior

Clicking on 'save' should save the config and allow me to login to Devtron using LDAP.

👎 Actual Behavior

I'm getting a "Some required fields are missing" error. I also tried to properly align with the fixed part above of the editable part, but it always snaps back to where it was.

☸ Kubernetes version

KFD-based cluster running Kubernetes v.1.29.3

Cloud provider

On-prem KFD installation.

🌍 Browser

Edge

🧱 Your Environment

I tried with

  • MS Edge 131.0.2903.112
  • Google Chrome 131.0.6778.265
  • Mozilla Firefox

✅ Proposed Solution

You should either make sure that the editable fields are properly aligned, or make the whole section editable so this doesn't happen. I could have worked around the issue if I could align things myself...

👀 Have you spent some time to check if this issue has been raised before?

  • [x] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

woopla avatar Jan 17 '25 22:01 woopla

@woopla can you confirm whether the final rended yaml after you save is correct for dex.config key in devtron-secret in devtroncd namespace?

pawan-mehta-dt avatar Jan 20 '25 10:01 pawan-mehta-dt

@pawan-mehta-dt it's empty:

> k get -n devtroncd secret/devtron-secret -o jsonpath='{.data}' | jq '."dex.config"'
""

(I checked k get -n devtroncd secret/devtron-secret -o yaml to be sure, other things like ADMIN_PASSWORD are there as expected).

It's refusing to save the config because of this "missing" field.

woopla avatar Jan 21 '25 23:01 woopla

@pawan-mehta-dt can you please share an example of a proper dex.config string, so I can try and set it manually in the secret?

woopla avatar Jan 27 '25 23:01 woopla

@pawan-mehta-dt any example for me here?

woopla avatar Feb 03 '25 19:02 woopla

I went ahead a created a YAML file, then shoved it into dex.config as a base64-encoded string. Nothing happens, I do not see anything in the UI. Either that field gets ignored, or errors preventing it from loading are ignored.

woopla avatar Feb 04 '25 02:02 woopla

  dex.config: |
    connectors:
    - config:
        bindDN: uid=admin,ou=people,dc=devtron,dc=local
        bindPW: ••••••••
        groupSearch:
          baseDN: ou=groups,dc=devtron,dc=local
          filter: (objectClass=groupOfUniqueNames)
          nameAttr: cn
          userMatchers:
            - groupAttr: member
              userAttr: DN
        host: lldap-service.devtron-demo:3890
        insecureNoSSL: true
        insecureSkipVerify: true
        userSearch:
          baseDN: ou=people,dc=devtron,dc=local
          emailAttr: mail
          idAttr: uid
          nameAttr: displayName
          preferredUsernameAttr: uid
          username: uid
        usernamePrompt: ••••••••
      id: ldap
      name: LDAP
      type: ldap

This is an example of Working dex config @woopla We can also schedule a call and debug the issue if you are stuck with it, fill a form with your work email and we'll schedule a call on the same to debug the issue. https://oss-support.devtron.ai

pawan-mehta-dt avatar Feb 04 '25 13:02 pawan-mehta-dt

I changed the secret to match that, and restarted all the pods in the devtroncd namespace, but no luck - it's still showing the default config, not this one. What do I need to do to get the updated secret to be used by devtron?

woopla avatar Feb 06 '25 01:02 woopla

@woopla Let me know if you have filled out the form, I'll schedule a call for the same with you. Please share the date and time when you filled the form

pawan-mehta-dt avatar Feb 06 '25 05:02 pawan-mehta-dt

Sorry for the late reply @pawan-mehta-dt . I did fill the form with my work email on Feb 5.

woopla avatar Feb 12 '25 16:02 woopla

Were you able to find my form @pawan-mehta-dt ?

woopla avatar Feb 19 '25 01:02 woopla

Yes, @woopla Can you share any preferred time slot and your time zone to schedule a call?

pawan-mehta-dt avatar Feb 20 '25 11:02 pawan-mehta-dt

Time zone is US Pacific, and time slot would be 8-10 am. I know it's not the most convenient for you...

woopla avatar Feb 20 '25 22:02 woopla

@woopla does 10 AM PST Feb 25 work for you?

pawan-mehta-dt avatar Feb 24 '25 06:02 pawan-mehta-dt

I can do 30 minutes @pawan-mehta-dt

woopla avatar Feb 24 '25 18:02 woopla

Facing the same issue. Is this taken up for a fix?

himanshusaini111 avatar Mar 22 '25 20:03 himanshusaini111

Facing the same issue as well +1

sam-fraiday avatar Jun 19 '25 09:06 sam-fraiday

Hi @sam-fraiday, you must be a member of the organization 'devtron-labs' to add or remove labels.

systemsdt avatar Jun 19 '25 09:06 systemsdt

Fix for this for whoever is seeing this in the future. Click the green text under the orchestrator url section and save it again for it to work.

Image

sam-fraiday avatar Jun 19 '25 10:06 sam-fraiday

Hi @sam-fraiday, you must be a member of the organization 'devtron-labs' to add or remove labels.

systemsdt avatar Jun 19 '25 10:06 systemsdt