devtron icon indicating copy to clipboard operation
devtron copied to clipboard

feat: tls support for git and gitops

Open iamayushm opened this issue 1 year ago • 2 comments

Description

Fixes #

Checklist:

  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] Does this PR requires documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have tested it for all user roles.
  • [ ] I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


iamayushm avatar Jun 14 '24 03:06 iamayushm

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9498692 Triggered Generic Password bd746ca1db7e8df484cc572d765f88c978a2a850 pkg/gitops/GitOpsConfigService.go View secret
9498692 Triggered Generic Password bd746ca1db7e8df484cc572d765f88c978a2a850 pkg/gitops/GitOpsConfigService.go View secret
141558 Triggered Generic High Entropy Secret 8badcf2f7e1954bbe8a8cde592869437d05cbcf0 scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/env-values.yaml View secret
2763127 Triggered Generic High Entropy Secret 8badcf2f7e1954bbe8a8cde592869437d05cbcf0 scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/secrets-test-values.yaml View secret
9498692 Triggered Generic Password c23ff3f18a8d87719d3b415062f84c06ade1a5c7 pkg/gitops/GitOpsConfigService.go View secret
9498692 Triggered Generic Password afbca2b382ecbf14164c188b2eb3299c6d0ba76b pkg/gitops/GitOpsConfigService.go View secret
10220829 Triggered Generic High Entropy Secret eb8fbb724f23544a4c8586bc02b777d975b71959 charts/devtron/devtron-bom.yaml View secret
10220829 Triggered Generic High Entropy Secret eb8fbb724f23544a4c8586bc02b777d975b71959 charts/devtron/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Jun 14 '24 03:06 gitguardian[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
25.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Aug 02 '24 11:08 sonarqubecloud[bot]