devtron icon indicating copy to clipboard operation
devtron copied to clipboard

fix: deploy detail info missing for copy container image artifact

Open iamayushm opened this issue 1 year ago • 5 comments

Description

fixes #4638, fixes #4401

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] Does this PR requires documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have tested it for all user roles.
  • [ ] I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


iamayushm avatar Feb 06 '24 10:02 iamayushm

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9404168 Triggered Username Password 735bdea3b035105e0e6b61cc13887d6db758f5c1 internal/util/ArgoUtil/ArgoClient.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Feb 08 '24 08:02 gitguardian[bot]

PR is not linked to any issue, please make the corresponding changes in the body.

github-actions[bot] avatar Feb 12 '24 05:02 github-actions[bot]

PR is not linked to any issue, please make the corresponding changes in the body.

github-actions[bot] avatar Feb 12 '24 05:02 github-actions[bot]

PR is not linked to any issue, please make the corresponding changes in the body.

github-actions[bot] avatar Feb 16 '24 07:02 github-actions[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 16 '24 07:02 sonarqubecloud[bot]

PR is not linked to any issue, please make the corresponding changes in the body.

github-actions[bot] avatar Mar 21 '24 07:03 github-actions[bot]

pr ref https://github.com/devtron-labs/devtron/pull/4869

RajeevRanjan27 avatar Apr 02 '24 13:04 RajeevRanjan27