devstream icon indicating copy to clipboard operation
devstream copied to clipboard

:four_leaf_clover: `Proposal`: pkg/util Enhancement

Open jxs1211 opened this issue 3 years ago • 3 comments

What Would You Like to Add? Why Is This Needed?

After some code investigation, I found there are many plugins depend on the pkg/util, so I suppose it is quite important to make the package more solid, and the way to improve it is various:

  • better naming
  • better code organization
  • refactor to make it easier to test
  • ut
  • other aspect to make it stronger

Design

The tools in this directory have been divided into categories, like downloader\gitlab\github\k8s\helm, etc. So we could refactor it one by one, and create some sub task under this proposal,his could help us move faster and more stable.

Anything else

jxs1211 avatar Jul 11 '22 08:07 jxs1211

@hxcGit pls do me a favor to label this proposal with helpwant,refactor,enhancement,test

jxs1211 avatar Jul 11 '22 09:07 jxs1211

@jxs1211 That's right. I think the best way to start this job is to add some unit tests. Care to contribute some PR for it?

xavier-hou avatar Jul 11 '22 10:07 xavier-hou

@hxcGit Maybe we could add some sub task to do this

jxs1211 avatar Jul 12 '22 00:07 jxs1211