devstream icon indicating copy to clipboard operation
devstream copied to clipboard

:four_leaf_clover: `Proposal`: Plugin `githubactions-golang` Enhancement (sub-task of #513)

Open daniel-hutao opened this issue 3 years ago • 3 comments

What would you like to add? Why is this needed?

See #513 for the details

daniel-hutao avatar May 18 '22 09:05 daniel-hutao

tools:
- name: githubactions-golang
  instanceID: default
  dependsOn: []
  options:
    owner: YOUR_GITHUB_USERNAME
    org: YOUR_ORGANIZATION_NAME
    repo: YOUR_REPO_NAME
    language:
      name: go
      version: "1.17"
    branch: main
    build:
      enable: True
      command: "go build ./..."
    test:
      enable: True
      command: "go test ./..."
      coverage:
        enable: False
        profile: "-race -covermode=atomic"
        output: "coverage.out"
    docker:
      enable: True
      registry:
        type: dockerhub
        username: YOUR_DOCKERHUB_USERNAME
        repository: YOUR_DOCKERHUB_REPOSITORY

Same issue regarding the owner/org issue. See https://github.com/devstream-io/devstream/issues/516#issuecomment-1136999392 for more info.

Besides, we need a better usage example, with better docs explaining each param in detail. I.E., if it's mandatory, what it does, what it means, and the default values. Maybe provide a minimum config that could work as well.

Be Brave, Be Imaginative

Anything that isn't following the clean code best practice, refactor it.

Any feature you think would add value to end-users, add it.

Any configuration refactors / documentation updates that would improve the end users' quality of life, do it.

Be brave when deleting unnecessary code, and be imaginative when adding new features.

IronCore864 avatar May 25 '22 09:05 IronCore864

TODO

  • [ ] more general internal code implement

steinliber avatar Aug 04 '22 03:08 steinliber

Hi,after I read the issue, I learned that there is a improvement problem about plugin. One of my ideas about the field of yaml configuration in this issue should be similar to https://github.com/devstream-io/devstream/issues/516#issuecomment-1136999392. Set the org field as the bool attribute, which is false by default. When it is true, the owner plays the role of org. Because I am also a beginner of devstream, I hope to further learn devstream through this issue. Maybe I can have a try, I will learn more about devstream and give solutions in the following days.

CrazyCollin avatar Sep 18 '22 10:09 CrazyCollin