devstream icon indicating copy to clipboard operation
devstream copied to clipboard

:bomb: `Bug`: `dtm upgrade` download dtm into the wrong place

Open aFlyBird0 opened this issue 3 years ago • 4 comments

What Happened?

image

My dtm binary is in PATH, and I execute dtm upgrade in another path.

It should put the new dtm binary on PATH. But it download the latest dtm on the current path.

How to Reproduce?

Execute dtm upgrade on the dir different from where dtm is.

Anything else

If your workdir don't have dtm. The output will be like:

image

DevStream Version

latest

aFlyBird0 avatar Oct 13 '22 17:10 aFlyBird0

hi, i want this issues

Shuimo03 avatar Oct 17 '22 12:10 Shuimo03

hi, i want this issues

Happy Coding 👏

aFlyBird0 avatar Oct 17 '22 14:10 aFlyBird0

Thanks, but I seems liketo find one bugs? i use dtm upgrade and got the following error: ✖ [FATAL] rename /root/dtm/dtm /root/dtm/dtm-bak: no such file or directory

OS: centos7 golang: go1.19.1 linux/amd64

On Mon, 17 Oct 2022 at 22:12, Bird @.***> wrote:

hi, i want this issues

Happy Coding 👏

— Reply to this email directly, view it on GitHub https://github.com/devstream-io/devstream/issues/1172#issuecomment-1280927867, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFKP5D67PEUNK6GBP5UKEW3WDVNGLANCNFSM6AAAAAAREQJMKI . You are receiving this because you were assigned.Message ID: @.***>

Shuimo03 avatar Oct 19 '22 13:10 Shuimo03

Thanks, but I seems liketo find one bugs? i use dtm upgrade and got the following error: ✖ [FATAL] rename /root/dtm/dtm /root/dtm/dtm-bak: no such file or directory OS: centos7 golang: go1.19.1 linux/amd64 On Mon, 17 Oct 2022 at 22:12, Bird @.> wrote: hi, i want this issues Happy Coding 👏 — Reply to this email directly, view it on GitHub <#1172 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFKP5D67PEUNK6GBP5UKEW3WDVNGLANCNFSM6AAAAAAREQJMKI . You are receiving this because you were assigned.Message ID: @.>

That's where the bug is. 😀 Just fix it! (Find the correct path where dtm binary is).

Feel free to keep in touch with us. @Shuimo03

aFlyBird0 avatar Oct 19 '22 14:10 aFlyBird0

@Shuimo03 please link this issue to your open PR. Thanks! And great work on the PR!

IronCore864 avatar Oct 27 '22 02:10 IronCore864

@Shuimo03, a gentle reminder: this issue has been stale for a week. When you have time, please review the comments above and try to merge this one. Thanks :)

IronCore864 avatar Nov 03 '22 02:11 IronCore864

Merged.

IronCore864 avatar Nov 03 '22 02:11 IronCore864