devspace icon indicating copy to clipboard operation
devspace copied to clipboard

pass namespace to kubectl build to fix incluster bug

Open kuuji opened this issue 2 years ago • 2 comments

What issue type does this pull request address? (keep at least one, remove the others) /kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) resolves #2745

Please provide a short message that should be published in the DevSpace release notes Fixes an issue where DevSpace, when ran incluster, would deploy kubectl manifest files in the wrong namespace even when -n is provided on the command line.

What else do we need to know?

I'm not setup to run the e2e for this yet but I did test the fix with kubectl (not yet with kustomize). Since it's such a simple fix I figured I might as well open the PR to get some opinions while I do more testing.

kuuji avatar Oct 26 '23 19:10 kuuji

Deploy Preview for devspace-docs canceled.

Built without sensitive environment variables

Name Link
Latest commit 51a98e6c916bac84c2754d71d04505ecc281b4f6
Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/653ab861e68434000845dbbf

netlify[bot] avatar Oct 26 '23 19:10 netlify[bot]

@kuuji Thanks for the PR! It's always great to see community contributions!

I approved the e2e test run, so you should see some feedback through the GitHub Actions.

lizardruss avatar Oct 31 '23 18:10 lizardruss