devspace icon indicating copy to clipboard operation
devspace copied to clipboard

Allow adjusting devspace config on run_default_pipeline

Open hendrikheil opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? As discussed in the Slack channel, with devspace 6.0.0-alpha.13 there is currently only create_deployment [name] --from-file file.yaml to adjust the helm values on a pipeline run. This works and is generally fine, however it forces a user to overwrite the default (in my case dev) pipeline to achieve a relatively simple goal. I personally think it would be great if we could apply config patches on a devspace dev run without overwriting a default pipeline.

Which solution do you suggest? @LukasGentele suggested a --set flag for run_default_pipeline which could adjust the config without duplicating the default pipeline definition. With this approach it would probably be a good idea to also allow --set-from-file (or similar) as to not have huge pipeline definitions when there are more things to adjust.

Which alternative solutions exist? Alternatively allowing dev to define patches for a devspace dev run, similar to how profile patches work could work. I however I could see both options as being worthwhile to implement.

Additional context https://loft-sh.slack.com/archives/CDSV29U85/p1650347170419019

/kind feature

hendrikheil avatar Apr 19 '22 06:04 hendrikheil

@CiiDyR thanks for the issue! After internal discussions we have decided to add the --set flag to run_default_pipeline as well as run_pipelines that modifies the current config that will be passed to the pipeline execution.

FabianKramm avatar Apr 20 '22 08:04 FabianKramm