devryan
Everything updated to support user/admin choice of displaying the AJAX...
... warning message for leaving the page, defaults to on. Tested working in all situations (general usage, installing, updating) except when editing admin details, a commented out updated query in admin_actions.php from line 45 shows the attempted query which results in silent failure on the edit page. User updating is working fine however.
I'm sure you can easily figure out what needs doing to fix the admin edit problem, hence the pull request.
Thanks for the commit;
This requires a new DB field? That's a pretty big change to just merge in as it will break anyone's install until they run the upgrade script; it would also require incrementing the gpx version in the install. Also, is there still the bug that you mentioned where editing admin details breaks the page? Is that just because the DB field wasn't in your admins table?
That's a pretty big change to just merge in as it will break anyone's install until they run the upgrade script; it would also require incrementing the gpx version in the install.
That's taken care of in the commit.
Also, is there still the bug that you mentioned where editing admin details breaks the page? Is that just because the DB field wasn't in your admins table?
Yeah, it's still in there, the DB field is in the admins table though and all install/upgrade scripts also create it. It seems to be a problem with the query in ajax/admin_actions.php on line 44 but I couldn't figure out a good way to debug it as I was a bit tired. That is literally the only problem with this commit.
The DB field is necessary if you want user-level choice of the AJAX page close warning, I didn't want to do it half-arsed. People who are running GPX from the Git repository should be prepared for breakage if they are upgrading via Git pull, and they should be checking the upgrade script every time if they do.