Yaroslav Admin comments

Results 130 comments of


                                            Yaroslav Admin

disallow comparing to null and undefined unless they are valid cases in strict null mode

I would also like to have it implemented for the same reason as https://github.com/microsoft/TypeScript/issues/14764: vulnerable refactoring. This proposal is a bit more broad, then https://github.com/microsoft/TypeScript/issues/14764. Maybe they should be merged?...

[Feature] Return "engines" check

Ha-ha, funny! I've also made a very similar plugin couple of days back. https://github.com/devoto13/yarn-plugin-engines

Add x64AlpineLinux for Dragonwell 11

Is this issue tracking aarch64AlpineLinux, i.e. arm64 architecture for Alpine or should I open a separate feature request for that?

(feat): make fa-icon ChangeDetection.OnPush

I'm going to close it as stale and because I don't quite see how `ChangeDetection.OnPush` can improve the performance for the `fa-icon` component, but I'm happy to re-open it if...

Feature request (for docs): Security vulnerability policy

I'm going to close this issue as answered. At this point, `angular-fontawesome` is an open-source project primarily maintained by volunteers. Only the last version will receive patches on a best-effort...

Issue with self-hosted FontAwesome 6 pro

Closing as answered.

Icon size "xl" and others not included in SizeProp type

Fixed in `@fortawesome/[email protected]`.

Significantly improved addFile/changeFile/removeFile performance.

@jfstephe I don't have permissions to merge, so without somebody from Google, there is nothing I can do. And given the recent [karma deprecation announcement](https://github.com/karma-runner/karma#karma-is-deprecated-and-is-not-accepting-new-features-or-general-bug-fixes), I'm afraid that the most...

Fix TypeScript error caused by duplicate Request identifiers

You can use old version, 1.x works IIRC.

Feature request: Trusted Types support

I think setting policy to `angular#unsafe-bypass` per https://angular.io/guide/security#enforcing-trusted-types should work as we use Angular to set `innerHTML`. Or are you asking to add a dedicated policy for this library? Okay,...