binenv icon indicating copy to clipboard operation
binenv copied to clipboard

Installation of tool 'naabu' is not working in the lastest version

Open angrox opened this issue 4 years ago • 4 comments

The installation of naabu fails in the latest version 2.0.3:

binenv install naabu 2021-04-27T06:44:38Z WRN version for "naabu" not specified; using "2.0.3" 2021-04-27T06:44:38Z ERR unable to install "naabu" (2.0.3) error="unable to download binary at https://github.com/projectdiscovery/naabu/releases/download/v2.0.3/naabu_2.0.3_linux_amd64.tar.gz: 404 Not Found"

Reason: Project switched the filename deliminator from underscore to dash

Normally I would just fix it and open a PR but this only affects the latest version so changing it would break all older versions.

Any ideas of how to fix it?

angrox avatar Apr 27 '21 06:04 angrox

Thanks for the report @angrox . Interesting use case.

Well, for now we do not have many solutions:

  1. break backward compatibility
  2. add another entry in the distributions file (with a different name, e.g. nabu2)

Could be interesting in the future to have multiple URLs for fetch releases.

leucos avatar Apr 27 '21 07:04 leucos

I also thought of multiple URLs to check against but was unsure if such a PR would be accepted.

I am not happy with breaking backward compatibility neither with a second entry for the same tool. :-/

angrox avatar Apr 28 '21 07:04 angrox

I think this is a good idea. May be we can use :

fetch:
      urls:

so we preserve backward compatibility.

We'll keep fetch.url for a while until we bump major version.

What do you think ?

leucos avatar Apr 28 '21 07:04 leucos

I worked on this, see #252

xx4h avatar Mar 23 '24 14:03 xx4h