ansible-minecraft icon indicating copy to clipboard operation
ansible-minecraft copied to clipboard

Support Spigot

Open benwebber opened this issue 9 years ago • 5 comments

  • [x] Create a minecraft_server variable that defaults to vanilla minecraft
  • [x] Download BuildTools
  • [x] Run BuildTools with --rev {{ minecraft_version }} to build Spigot
  • [x] Update Supervisor/systemd templates to run Spigot
  • [x] Rename Supervisor/systemd services after implementation
  • [x] Update test suite

benwebber avatar Jul 17 '16 18:07 benwebber

So, should I expect this to work at this point? Which branch would I use to try it? Obviously, the JDK has to be installed for this to work...

danizen avatar Mar 08 '18 14:03 danizen

Definitely not working on master branch - I will proceed with the minecraft_url setting to download a copy of Spigot I've built and marshalled in place.

danizen avatar Mar 08 '18 14:03 danizen

master worked as of December:

https://travis-ci.org/devops-coop/ansible-minecraft/jobs/315195888

It is possible that the Spigot build script has changed. I don't personally use Spigot. Can you share the error message you got using the master branch?

benwebber avatar Mar 11 '18 08:03 benwebber

@danizen If you used ansible-galaxy to install from galaxy (ansible-galaxy install devops-coop.minecraft), then you won't have master with spigot support (setting minecraft_server: spigot doesn't fail - it just fetches and installs vanilla minecraft).

You need to use the github repo directly:

ansible-galaxy install git+https://github.com/devops-coop/ansible-minecraft.git

This was still giving me issues, but it's a simple fix: https://github.com/devops-coop/ansible-minecraft/pull/25/commits/ff6c5c8fec0686d445cc7e1e31a24dfb69f5052b

jaygooby avatar May 13 '18 11:05 jaygooby

Fair enough. FWIW, we all know we should mark an issue as resolved when it is fixed, and closed when the version containing the fix has "shipped" or been installed.

At the same time, if I use a role for work, I generally clone it and use it from my own repository rather than galaxy, because I don't want it to change under me, and I don't want to manage a galaxy repository in addition to our git installation!

danizen avatar May 13 '18 16:05 danizen