devlinjunker

Results 30 comments of devlinjunker

Updated the .editorconfig and those remaining spaces in the vue html @anoymouserver

after this is merged, we can move on to https://github.com/nextcloud/news/pull/1922 and I am currently working on adding unit tests for the existing components. See https://github.com/devlinjunker/news/pull/56 for the WIP changes so...

I created a PR here to try to do this: https://github.com/ui-router/angular/pull/967 not sure if anyone is around to help merge it though

@christopherthielen @oBusk any qualms with merging this and creating v10.0.0 release?

> What is the reason for the creation of the ng-package.json? https://github.com/ng-packagr/ng-packagr now requires a separate ng-package.json file rather than including the details in the package.json (you can compare the...

hmm.. not sure what to do with the current error in the CI: ``` npx check-peer-dependencies shell: /usr/bin/bash -e {0} ✅ ajv ^8.0.0 is required by [email protected] (8.11.0 is installed)...

I updated the `check-peer-dependencies` command and it looks like it is passing locally now

oh.. I didn't realize the ci.yml file had it's own definition of the `npx check-peer-dependencies`, I updated that in my branch to include `--runOnlyOnRootDependencies` But I guess I'm not sure...

can we approve the workflow again to see if it is fixed @dereekb @wawyed @christopherthielen ?

@wawyed think you can help out?