devland
devland
h5p-cli core functionality has been rewritten. Closing this since it is no longer relevant.
The `important-description-open/0` end-point is not implemented. It is used to save the show/hide instructions state within the editor. We'll look into implementing it.
The weird thing is that this happens only on some systems. For me it does not happen but for a colleague of mine it does and we're both running the...
We managed to reproduce this again on v0.5.16 and on master branch as of writing this (https://github.com/cthackers/adm-zip/commit/1cd32f7e0ad3c540142a76609bb538a5cda2292f). To reproduce locally run `extractAllTo` on the below attached zip file. [descriptorMalformed.zip](https://github.com/user-attachments/files/18887751/descriptorMalformed.zip) The...
I cannot reproduce this either. On Windows it is recommended that you run the h5p-cli commands inside [git bash](https://git-scm.com/downloads).
I managed to reproduce this issue on my windows vm. It seems that the adm-zip npm module works inconsistently between OSs.
Fixed by updating adm-zip to v0.5.16. https://github.com/h5p/h5p-cli/pull/127 Should be merged to master soon with a new npm version to be pushed out shortly after that. @otacke Can you check if...
@otacke No, that's for Linux on your own system. I remember that you reported the issue from https://github.com/cthackers/adm-zip/issues/533 but I could not reproduce it so [I pinned adm-zip at 0.5.14](https://github.com/h5p/h5p-cli/commit/403392cb845d4745afe9a8ba431b7903d8ddc344)...
@otacke I can also reproduce the error with your sample content. It's generated by this line in adm-zip: https://github.com/cthackers/adm-zip/blob/1cd32f7e0ad3c540142a76609bb538a5cda2292f/zipEntry.js#L62 when `descriptor.size` does not match `_centralHeader.size`. For our example the values...
Issue fixed. v1.1.3 of the h5p-cli has been pushed to the npm registry.