devito icon indicating copy to clipboard operation
devito copied to clipboard

Rename `ir.clusters.visitors.Queue`

Open enwask opened this issue 7 months ago • 2 comments

The Queue cluster visitor is confusingly named for something that performs a divide-and-conquer process; I'd propose renaming it to something but not sure what. Specifically making this issue because I'm starting to write some threaded code relating to these Queues and will be making heavy use of the built-in queue.Queue which clashes.

Didn't want to go ahead and rename this yet as there are a bunch of uses in subclassed visitors (not sure if these are extended in pro) so I think it's a reasonably nontrivial change

enwask avatar Jun 20 '25 11:06 enwask

Ooof, clashing with a Python built-in is not ideal! Is this exposed and/or used in the public API or just internally?

JDBetteridge avatar Jun 20 '25 11:06 JDBetteridge

Purely used internally iirc

EdCaunt avatar Jun 20 '25 11:06 EdCaunt