devito icon indicating copy to clipboard operation
devito copied to clipboard

dsl: Introduce ability to define Functions on Subdomains

Open EdCaunt opened this issue 2 years ago • 2 comments

Add Functions on SubDomains functionality.

Remaining todo:

  • Tutorial notebook showing
    • Demo for seafloor-like configuration
    • Demo for damping-like configuration
    • Demo for snapshotting only one region of the grid
  • Change subdomain numbering to be more robust and prevent memory leaks
  • Tests for propagator on subdomain
    • Including with MPI

EdCaunt avatar Oct 24 '23 16:10 EdCaunt

Codecov Report

Attention: Patch coverage is 96.04830% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 86.98%. Comparing base (7fca4a8) to head (c868c91).

Files Patch % Lines
devito/types/grid.py 80.85% 18 Missing :warning:
devito/types/dimension.py 70.00% 4 Missing and 2 partials :warning:
devito/mpi/distributed.py 95.72% 3 Missing and 2 partials :warning:
devito/types/sparse.py 20.00% 4 Missing :warning:
devito/data/decomposition.py 97.29% 0 Missing and 1 partial :warning:
tests/test_interpolation.py 99.39% 0 Missing and 1 partial :warning:
tests/test_mpi.py 98.82% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
+ Coverage   86.80%   86.98%   +0.17%     
==========================================
  Files         233      233              
  Lines       43755    44534     +779     
  Branches     8078     8237     +159     
==========================================
+ Hits        37983    38739     +756     
- Misses       5063     5082      +19     
- Partials      709      713       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 24 '23 17:10 codecov[bot]

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB