Austin Devine
Austin Devine
@henri-kohlberg Yes i think it makes sense to support @typescript-eslint/* V7 (also eslint v8 ). I will need to check some pipelines to check for compatibility and also the project...
@henri-kohlberg This was completed in https://github.com/SAP/open-ux-tools/pull/1738. Sorry I forgot to update here at the time. I'll close this. Please let me know if there is anything else needed.
@IainSAP I think the original application should be removed by the generator before the writing starts. This would avoid reading the original file in case of JS. For JSON files...
@815are thanks for the review and updates.
Thanks all
Linter issues fixed for newer ui5 versions GTE 1.120.0 in https://github.com/SAP/open-ux-tools/pull/2334 Hopefully soon with https://github.com/SAP/open-ux-tools/issues/2172 it will no longer be needed.
Putting on hold.
> @devinea @heimwege > > Would it make sense to change version of `@sap-ux/eslint-plugin-fiori-tools` to 9.0.0 to reflect eslint compatibility? @Klaus-Keller yes. Done in https://github.com/SAP/open-ux-tools/pull/3788/commits/4a4c24cba07a379f6ca97e26428c32ab6e25997f
@heimwege Looking at this again I think we we can use `ui5Json.libraries.map(lib => lib.name)` to replace the static list of namespaces (which was a short cut to knowing the library...
I recently encountered an internal ui5 library matching the a namespace in the static list but not part of standard UI5 delivered libraries. So I think better to move away...