devine icon indicating copy to clipboard operation
devine copied to clipboard

-l all flag should probably take all lang instead of take all tracks

Open kannarima opened this issue 1 year ago • 4 comments

Is your feature request related to a problem? Please describe. When -l all is supplied, devine take all audio tracks

image

Describe the solution you'd like devine should take only 1 track per lang

Describe alternatives you've considered

title.tracks.audio = title.tracks.by_language(
    title.tracks.audio,
    (list(set([t.language.to_alpha3() for t in title.tracks.audio])) if 'all' in lang else lang),
    per_language=1
)

kannarima avatar Apr 03 '24 07:04 kannarima

This is my stupid work-around to grab the highest quality for each language available.

devine dl -l ab,aa,af,ak,sq,am,ar,an,hy,as,av,ae,ay,az,bm,ba,eu,be,bn,bi,bs,br,bg,my,ca,ch,ce,ny,zh,cu,cv,kw,co,cr,hr,cs,da,dv,nl,dz,en,eo,et,ee,fo,fj,fi,fr,fy,ff,gd,gl,lg,ka,de,el,kl,gn,gu,ht,ha,he,hz,hi,ho,hu,is,io,ig,id,ia,ie,iu,ik,ga,it,ja,jv,kn,kr,ks,kk,km,ki,rw,ky,kv,kg,ko,kj,ku,lo,la,lv,li,ln,lt,lu,lb,mk,mg,ms,ml,mt,gv,mi,mr,mh,mn,na,nv,nd,nr,ng,ne,no,nb,nn,ii,oc,oj,or,om,os,pi,ps,fa,pl,pt,pa,qu,ro,rm,rn,ru,se,sm,sg,sa,sc,sr,sn,sd,si,sk,sl,so,st,es,su,sw,ss,sv,tl,ty,tg,ta,tt,te,th,bo,ti,to,ts,tn,tr,tk,tw,ug,uk,ur,uz,ve,vi,vo,wa,cy,wo,xh,yi,yo,za,zu <service> <title>

Sp5rky avatar Apr 03 '24 14:04 Sp5rky

Is your feature request related to a problem? Please describe. When -l all is supplied, devine take all audio tracks

image

Describe the solution you'd like devine should take only 1 track per lang

Describe alternatives you've considered

title.tracks.audio = title.tracks.by_language(
    title.tracks.audio,
    (list(set([t.language.to_alpha3() for t in title.tracks.audio])) if 'all' in lang else lang),
    per_language=1
)

Not related to your suggestion, but what is the name of the font you are using on your terminal?

WalkerTheWolfXXII avatar Apr 05 '24 20:04 WalkerTheWolfXXII

Is your feature request related to a problem? Please describe. When -l all is supplied, devine take all audio tracks image Describe the solution you'd like devine should take only 1 track per lang Describe alternatives you've considered

title.tracks.audio = title.tracks.by_language(
    title.tracks.audio,
    (list(set([t.language.to_alpha3() for t in title.tracks.audio])) if 'all' in lang else lang),
    per_language=1
)

Not related to your suggestion, but what is the name of the font you are using on your terminal?

Cascadia Code 👍

kannarima avatar Apr 06 '24 00:04 kannarima

Is your feature request related to a problem? Please describe. When -l all is supplied, devine take all audio tracks image Describe the solution you'd like devine should take only 1 track per lang Describe alternatives you've considered

title.tracks.audio = title.tracks.by_language(
    title.tracks.audio,
    (list(set([t.language.to_alpha3() for t in title.tracks.audio])) if 'all' in lang else lang),
    per_language=1
)

Not related to your suggestion, but what is the name of the font you are using on your terminal?

Cascadia Code 👍

I have it installed, but it doesn't look like yours. 🤔

WalkerTheWolfXXII avatar Apr 12 '24 01:04 WalkerTheWolfXXII