bsnes-plus icon indicating copy to clipboard operation
bsnes-plus copied to clipboard
verified publisher icon devinacker

Register values in debugger window cropped in lxqt with breeze theme

Open eduardomezencio opened this issue 8 years ago • 7 comments

Register values in debugger window show cropped in lxqt with breeze theme, as shown in attachment: screen

eduardomezencio avatar Feb 17 '17 03:02 eduardomezencio

After testing it for a while, I found out that the qt Breeze theme have some larger borders that you can't change with the QLineEdit textMargins property. Even with all margins set to zero the problem persists. However, if I set my GTK+ theme to Breeze and then set qt4 theme to GTK+ in qtconfig-qt4, I can get an interface that is quite similar to Breeze, but this problem is gone, so that's what I'm doing right now. I'm not closing this issue so that you decide yourself what to do. I see that in the source code the width of the register QLineEdit is set to the width of number of chars + 1. Setting it to number of char + 2 may solve the problem, without causing much trouble.. but I don't know if this approach is too hacky for you.

eduardomezencio avatar Feb 17 '17 18:02 eduardomezencio

Someone on the NESDev forums brought up the same issue some time ago and I had considered the same solution (i.e. making the fields 1 character longer).

Since it's possible that the project may be switching to Qt 5 at some point in the future, I'm kind of curious if Qt 5 has the same issue with the borders/margins. In the meantime, there's plenty of room on the window to just widen the text boxes a bit, so I might do that anyway.

devinacker avatar Feb 17 '17 18:02 devinacker

If you are able to build from source (and identify possible build issues since building on windows can be rather finicky), you can try my branch which is already on Qt5.

Optiroc avatar Feb 17 '17 18:02 Optiroc

@devinacker the branch @Optiroc maintains builds fine with Qt5. Maybe the Qt5 support can be pulled in?

BooBerry avatar Mar 14 '17 12:03 BooBerry

Can you verify whether or not the same thing occurs with the new debugger GUI now that the project has moved to Qt5?

devinacker avatar Aug 27 '19 23:08 devinacker

I'm not using a Qt-based desktop now, so I cannot test with a similar environment.. but I tried to compile from master to test anyways and could not open a rom. The open file dialog does not show up when I select Load Cartridge.

eduardomezencio avatar Sep 05 '19 18:09 eduardomezencio

Hmm, weird.

Couple of suggestions:

  • Try either enabling or disabling "use native OS file dialogs" (Settings > Configuration > Advanced)
  • If you've ever run bsnes-plus previously as the same user, try opening ~/.bsnes/bsnes-qt.cfg and deleting the geometry.fileBrowser line

devinacker avatar Sep 08 '19 02:09 devinacker