devicon icon indicating copy to clipboard operation
devicon copied to clipboard

new icon: filamentphp (original)

Open AnshSinghSonkhia opened this issue 1 year ago • 6 comments

Double check these details before you open a PR

  • [x] PR does not match another non-stale PR currently opened
  • [x] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • [x] PR's base is the develop branch.
  • [x] Your icons are inside a folder as seen here
  • [x] SVG matches the standards laid out here
  • [x] A new object is added in the devicon.json file as seen here

This PR closes #2120

Link to prove your SVG is correct and up-to-date.

https://filamentphp.com/

AnshSinghSonkhia avatar Jan 29 '24 17:01 AnshSinghSonkhia

  • Instead of plain-wordmark call the SVG original as the icon you added is the original filamentphp logo.
  • Optimize and clean up the SVG like we did in the remix pr. Because the SVG only has 1 color, you can combine the paths into 1 path; This reduces the size of the svg and makes it possible for us the svg as an base/ alias for other version.

These changes are done!!

AnshSinghSonkhia avatar Mar 08 '24 05:03 AnshSinghSonkhia

  • Because there is only 1 path and fill color you can use the filamentphp-original.svg as the base and make aliases for original-wordmark, plain, and plain-wordmark.

Made some changes in devicon.json

"aliases": [
            {
                "base": "original",
                "alias": [
                    "original-wordmark",
                    "plain",
                    "plain-wordmark"
                ]
            }
        ]

Kindly. verify it @canaleal

AnshSinghSonkhia avatar Mar 08 '24 05:03 AnshSinghSonkhia

By the way, the SVG has a fill="currentColor" and class="transition duration-300 will-change-transform group-hover/filament:-translate-x-[1.2rem] motion-reduce:transition-none" that can be removed.

canaleal avatar Mar 08 '24 07:03 canaleal

By the way, the SVG has a fill="currentColor" and class="transition duration-300 will-change-transform group-hover/filament:-translate-x-[1.2rem] motion-reduce:transition-none" that can be removed.

Done, anymore changes required?

AnshSinghSonkhia avatar Mar 08 '24 07:03 AnshSinghSonkhia

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Mar 09 '24 00:03 github-actions[bot]

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Mar 09 '24 00:03 github-actions[bot]