devicons
bugfix/fix: add default colors to Font versions
Double check these details before you open a PR
- [x] PR does not match another non-stale PR currently opened
Features
Add default colors to the icons listed below. And some adjustments on other icons of the same technology.
adonisjs: [original-wordmark]
angular: [plain, plain-wordmark]
apache: [plain, plain-wordmark, line, line-wordmark]
apacheairflow: [plain, plain-wordmark]
apachespark: [plain-wordmark]
apl: [plain]
argocd: [plain, plain-wordmark]
astro: [plain, plain-wordmark]
babel: [plain]
bootstrap: [plain, plain-wordmark]
browserstack: [plain, plain-wordmark]
bun: [plain, line]
cairo: [plain, plain-wordmark]
cassandra: [plain, plain-wordmark]
centos: [plain, plain-wordmark]
clarity: [plain, plain-wordmark]
clion: [plain-wordmark]
consul: [plain-wordmark]
couchbase: [plain-wordmark]
datagrip: [plain-wordmark]
dataspell: [plain-wordmark]
djangorest: [plain, plain-wordmark, line, line-wordmark]
dreamweaver: [plain, line]
dynamodb: [plain]
ecto: [plain-wordmark]
eleventy: [plain]
elixir: [plain, plain-wordmark]
embeddedc: [plain, plain-wordmark]
ember: [plain]
figma: [plain]
fsharp: [plain]
gazebo: [plain, plain-wordmark]
gcc: [plain, line]
go: [plain, line]
godot: [plain, plain-wordmark]
goland: [plain-wordmark]
grails: [plain]
groovy: [plain]
grpc: [plain]
hadoop: [plain, plain-wordmark]
hardhat: [plain, plain-wordmark]
haskell: [plain, plain-wordmark]
homebrew: [plain, plain-wordmark, line, line-wordmark]
insomnia: [plain, plain-wordmark]
intellij: [plain-wordmark]
jamstack: [plain-wordmark]
jekyll: [plain, plain-wordmark]
jenkins: [plain, line]
jetbrains: [plain]
jira: [plain, plain-wordmark]
jiraalign: [plain, plain-wordmark]
julia: [plain, plain-wordmark]
jupyter: [plain, plain-wordmark]
kdeneon: [plain]
keras: [plain, plain-wordmark, line, line-wordmark]
knexjs: [plain-wordmark]
ktor: [plain-wordmark]
labview: [plain, plain-wordmark]
linkedin: [plain, plain-wordmark]
llvm: [plain]
materializecss: [plain]
matlab: [plain]
maven: [plain, plain-wordmark]
neo4j: [plain, plain-wordmark]
neovim: [plain, plain-wordmark, line, line-wordmark]
netlify: [plain, plain-wordmark]
ngrx: [plain]
nimble: [plain]
nomad: [plain-wordmark]
norg: [plain]
notion: [plain, line]
nuxtjs: [plain, plain-wordmark]
ocaml: [plain, plain-wordmark]
opencv: [plain, plain-wordmark]
openstack: [plain-wordmark]
perl: [plain]
phoenix: [plain-wordmark]
php: [plain]
phpstorm: [plain-wordmark]
playwright: [plain]
plotly: [plain, plain-wordmark]
pnpm: [plain, plain-wordmark]
podman: [plain, plain-wordmark]
polygon: [plain, plain-wordmark]
powershell: [plain]
pycharm: [plain, plain-wordmark]
pypi: [plain, plain-wordmark]
qodana: [plain-wordmark]
rabbitmq: [plain-wordmark]
reach: [plain]
readthedocs: [line]
realm: [plain, plain-wordmark]
renpy: [plain]
rider: [plain-wordmark]
rockylinux: [plain-wordmark]
rubymine: [plain-wordmark]
scikitlearn: [plain, line]
reactrouter: [plain, plain-wordmark]
solidjs: [plain, plain-wordmark]
spack: [plain]
sqlite: [plain, plain-wordmark]
stackoverflow: [plain, plain-wordmark, line, line-wordmark]
storybook: [plain, plain-wordmark]
supabase: [plain, plain-wordmark]
svelte: [plain, plain-wordmark]
swagger: [plain, plain-wordmark]
swift: [plain, plain-wordmark]
swiper: [original]
tailwindcss: [plain-wordmark]
tauri: [plain, plain-wordmark]
terraform: [plain, plain-wordmark]
thealgorithms: [plain, plain-wordmark]
tomcat: [line, line-wordmark]
tortoisegit: [plain, line]
trpc: [plain, plain-wordmark]
ubuntu: [plain, plain-wordmark]
unity: [plain, plain-wordmark, line, line-wordmark]
vagrant: [plain, plain-wordmark]
vala: [plain, plain-wordmark]
vault: [plain-wordmark]
vitejs: [plain]
vitess: [plain, plain-wordmark]
vitest: [plain]
vscode: [plain, plain-wordmark]
wasm: [plain-wordmark]
webstorm: [plain-wordmark]
yaml: [plain]
yarn: [line, line-wordmark]
yii: [plain, plain-wordmark]
yugabytedb: [plain, plain-wordmark]
zig: [plain-wordmark]
This PR closes #2105 - [LP] Add default color
Notes
The code to add colors can be found here: https://gist.github.com/lunatic-fox/fdb53e596701fe12cbe38030ac4e5f6b
@lunatic-fox I find it really hard to review this PR because the diff says the whole file changed. Do you know of any easy way to see the exact differences, or do you have any other tips for reviewing this PR?
@lunatic-fox I find it really hard to review this PR because the diff says the whole file changed. Do you know of any easy way to see the exact differences, or do you have any other tips for reviewing this PR?
Maybe slicing it into around 10 - 20 icons per pull request, that way I think GitHub will be able to render it properly.
@lunatic-fox I think the issue is that GitHub has trouble rendering single-line diffs. I've seen this issue on multiple new icon PRs before too, so I don't think it's because of the amount of svg's
@lunatic-fox I think the issue is that GitHub has trouble rendering single-line diffs. I've seen this issue on multiple new icon PRs before too, so I don't think it's because of the amount of svg's
Hmm, so in that case, maybe I can prettify the output svgs. However, we should test if the web vscode shows the diffs first.
@lunatic-fox good idea. I created a codespace here: https://musical-space-invention-ppj4wj4vwj4c9rgj.github.dev/
@lunatic-fox
The diff in web-vscode is better, but it's still a bit hard to see the changes imo, since some things have just been moved, but are shown as removed/added
@Snailedlt I still don't see a better option to review the code beside web vscode viewer. However, I can improve the way of previewing it by creating a comment with a list like that:
| Tech name | devicons:develop | lunatic-fox:fx-add-default-colors |
|---|---|---|
| apl |  |
 |
@lunatic-fox yeah me neither :/ Previewing isn't any problem, so no need doing that. If the icons are used as a font, and yoyu changed anything besides the fill color we also need to preview the fonts on icomoon. If you could upload screenshots from there it'll go much faster to review! :D
This commit also modifies godot-original, jekyll-original, jekyll-original-wordmark, neo4j-original
and neo4j-original-wordmark, because their plain versions are smaller than 128px.
The icons listed below have to be off-colored since white has no contrast on itself.
-
angular-plain -
angular-plain-wordmark -
notion-line -
notion-plain
...
Well... It seems that I can't upload any image, so here's a zip file containing the screenshots. Screenshots.zip
Vscode plain wordmark version has some artifacts:
Other than that everything looks great!
Fixed!
@canaleal I think that's just visually on icomoon. Iirc from reviewing the notion PR, the icons are sized and centered correctly, but icomoon has some sort of negative padding issue, which is why it looks like it goes outside the viewbox. We should definitely double check tho, but as you say it's not critical and can be fixed later if it's an issue