devicon icon indicating copy to clipboard operation
devicon copied to clipboard

new icon: detaspace (original, original-wordmark, line, line-wordmark)

Open lemonyte opened this issue 2 years ago • 9 comments

Double check these details before you open a PR

  • [x] PR does not match another non-stale PR currently opened
  • [x] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • [x] PR's base is the develop branch.
  • [x] Your icons are inside a folder as seen here
  • [x] SVG matches the standards laid out here
  • [x] A new object is added in the devicon.json file at the correct alphabetic position as seen here
  • This PR closes #1845

Link to prove your SVG is correct and up-to-date.

https://deta.space/ https://github.com/deta https://deta.space/landing-page/assets/logo.20539aa2.svg https://github.com/deta/space-docs/blob/main/.github/deta.svg

lemonyte avatar Aug 24 '23 00:08 lemonyte

@lemonyte Let us know if you need any help with this one :)

Snailedlt avatar Oct 30 '23 22:10 Snailedlt

The blocker here is that a plain version of the icon would look like a plain circle. I don't want to move forward with modifications to the icon without approval from @abdelhai , so for now let's just keep this a draft.

lemonyte avatar Oct 30 '23 22:10 lemonyte

Fair enough! I do have an idea for how the icon could be modified, I can try to upload an example soon so you can see if you want :)

Snailedlt avatar Oct 30 '23 22:10 Snailedlt

I can try to upload an example soon so you can see if you want

Sure! I should have been more clear: I'm open to discuss modifications, but would like to hold off on merging any modified icons without approval 😄

lemonyte avatar Oct 30 '23 23:10 lemonyte

Small suggestion, but for the plain SVG it could be a could be a circle with white spacing in between each path. Not exactly a perfect solution, but I don't see another clear way to not make it look like a big 1 color circle.

image

If a plain SVG cannot be made, a line SVG can be used for the font version. Similar to how the Sketch Icon only has an original and line version.

image

canaleal avatar Nov 01 '23 18:11 canaleal

The line version looks good!

Snailedlt avatar Nov 01 '23 22:11 Snailedlt

Hi @Snailedlt, what are your thoughts on merging this? I believe all the issues have been resolved here.

lemonyte avatar May 20 '24 09:05 lemonyte

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar May 20 '24 11:05 github-actions[bot]

It seems that the threedsmax and reactrouter icons in devicon.json are causing the check to fail. The detaspace icon is in the correct alphabetical position.

lemonyte avatar May 21 '24 00:05 lemonyte

@Snailedlt is this good to merge? Please let me know if there is anything else to address in this PR :)

lemonyte avatar Jun 21 '24 22:06 lemonyte

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Jun 22 '24 05:06 github-actions[bot]

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Jun 22 '24 05:06 github-actions[bot]