devicon icon indicating copy to clipboard operation
devicon copied to clipboard

new icon: materializecss (original, plain)

Open AbdelrahmanDwedar opened this issue 3 years ago • 14 comments

Double check these details before you open a PR

  • [x] PR does not match another non-stale PR currently opened
  • [x] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • [x] PR's base is the develop branch.
  • [x] Your icons are inside a folder as seen here
  • [x] SVG matches the standards laid out here
  • [x] A new object is added in the devicon.json file as seen here

This PR closes #1345

Link to prove your SVG is correct and up-to-date.

https://materializecss.github.io/materialize/res/materialize.svg

AbdelrahmanDwedar avatar Aug 24 '22 14:08 AbdelrahmanDwedar

It's my first time contributing here, so I'm not quite sure if 100% of things are actually right.

AbdelrahmanDwedar avatar Aug 24 '22 14:08 AbdelrahmanDwedar

Oops I added the changes in AbdelrahmanDwedar:master and merged by accident!! 😵‍💫

That's embarrassing, sorry.

AbdelrahmanDwedar avatar Aug 24 '22 14:08 AbdelrahmanDwedar

Hi!

I'm the check-bot and we have some issues with your PR:

Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/materializecss/materializecss-original.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Aug 24 '22 14:08 github-actions[bot]

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'materializecss-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Aug 24 '22 21:08 github-actions[bot]

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'materializecss-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Aug 26 '22 04:08 github-actions[bot]

I'm very sorry for the late response, I was (and still) out of internet, it'll get better next week hopefully, and the I'll continue everything needed.

Hey there! Could you please follow the steps/address what the bot mentioned earlier? Let us know if you need any help with that here in our Discord community. 🙂

__ sema-logo  Summary: :hammer_and_wrench: This code needs a fix  |  Tags: Not maintainable

I actually don't quite know how to make that icon plain, is there any recommended application or web app that could be used for that or I may just edit fhe svg file's code to set all the colors to only one?

AbdelrahmanDwedar avatar Sep 06 '22 11:09 AbdelrahmanDwedar

I'm very sorry for the late response, I was (and still) out of internet, it'll get better next week hopefully, and the I'll continue everything needed.

Hey there! Could you please follow the steps/address what the bot mentioned earlier? Let us know if you need any help with that here in our Discord community. 🙂 __

I actually don't quite know how to make that icon plain, is there any recommended application or web app that could be used for that or I may just edit fhe svg file's code to set all the colors to only one?

You just need to make a file named materializecss-plain.svg and set all the colors to one simple color. In this case, we can use #EB7077, which is the main color of the icon set in devicon.json.

Let us know if you need any help! Thank you. 🙂

Panquesito7 avatar Sep 06 '22 15:09 Panquesito7

I'm very sorry for the late response, I was (and still) out of internet, it'll get better next week hopefully, and the I'll continue everything needed.

Hey there! Could you please follow the steps/address what the bot mentioned earlier? Let us know if you need any help with that here in our Discord community. slightly_smiling_face __

I actually don't quite know how to make that icon plain, is there any recommended application or web app that could be used for that or I may just edit fhe svg file's code to set all the colors to only one?

You just need to make a file named materializecss-plain.svg and set all the colors to one simple color. In this case, we can use #EB7077, which is the main color of the icon set in devicon.json.

Let us know if you need any help! Thank you. slightly_smiling_face

I've added the requested changes, inform me if there's anything else missing.
And thanks for helping. 🤝

AbdelrahmanDwedar avatar Sep 12 '22 14:09 AbdelrahmanDwedar

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'materializecss-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Sep 12 '22 17:09 github-actions[bot]

Is there anything left?

AbdelrahmanDwedar avatar Sep 12 '22 19:09 AbdelrahmanDwedar

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'materializecss-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'materializecss-plain.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

github-actions[bot] avatar Sep 13 '22 04:09 github-actions[bot]

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs: Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons: Imgur Images

Here are the colored versions: Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

github-actions[bot] avatar Sep 13 '22 04:09 github-actions[bot]

I'm not sure how to solve this, is it caused by the height?

Any help?

AbdelrahmanDwedar avatar Sep 15 '22 12:09 AbdelrahmanDwedar

You need to resize the icon, I think. Try using one of our recommended tools.

Panquesito7 avatar Sep 15 '22 15:09 Panquesito7

Sorry but I couldn't do it, can someone do it?

AbdelrahmanDwedar avatar Sep 24 '22 16:09 AbdelrahmanDwedar

I'll try re-working this tomorrow. Thanks. 🙂

Panquesito7 avatar Oct 06 '22 03:10 Panquesito7

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs: Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons: Imgur Images

Here are the colored versions: Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

github-actions[bot] avatar Oct 09 '22 20:10 github-actions[bot]

I moved it above Material UI but for the second task I'm not sure how to do it from my phone now as I currently can't use a laptop.

If possible could you give it to me as "mergable" edit so I can add it with one click, and sorry for bothering.

AbdelrahmanDwedar avatar Oct 14 '22 18:10 AbdelrahmanDwedar

I moved it above Material UI but for the second task I'm not sure how to do it from my phone now as I currently can't use a laptop.

If possible could you give it to me as "mergable" edit so I can add it with one click, and sorry for bothering.

Nice, thank you. I'll add it to my backlog, got no time just now, but hopefully sometime this weekend :)

Snailedlt avatar Oct 14 '22 18:10 Snailedlt

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs: Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons: Imgur Images

Here are the colored versions: Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

github-actions[bot] avatar Oct 14 '22 20:10 github-actions[bot]

I resized it as requested please inform me if there's something else need to fix or check out.

Also about the little tiny gap between figures in the plain version I think it makes more sense to leave as it gives you idea about the logo more. I think that gaps was already in the original one too but wasn't appearing as there's different colors in it.

AbdelrahmanDwedar avatar Nov 17 '22 13:11 AbdelrahmanDwedar

I guess that's all, not sure if I should also follow the next message after it. Is it necessary in out case or just there?

AbdelrahmanDwedar avatar Nov 22 '22 12:11 AbdelrahmanDwedar

I see, I'll fix it now

AbdelrahmanDwedar avatar Nov 22 '22 16:11 AbdelrahmanDwedar

Is that all?

AbdelrahmanDwedar avatar Nov 22 '22 16:11 AbdelrahmanDwedar

Yeah, looks like that's all :) Just gonna run some checks to see before approving :+1:

Snailedlt avatar Nov 22 '22 18:11 Snailedlt

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs: Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons: Imgur Images

Here are the colored versions: Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

github-actions[bot] avatar Nov 22 '22 18:11 github-actions[bot]

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs: Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons: Imgur Images

Here are the colored versions: Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

github-actions[bot] avatar Nov 22 '22 22:11 github-actions[bot]

Besides, seem that their SVG logo have some issues though. 🤔

lunatic-fox avatar Nov 22 '22 22:11 lunatic-fox