devicon icon indicating copy to clipboard operation
devicon copied to clipboard

new icon: hardhat (original)

Open knight-95 opened this issue 3 years ago • 9 comments

Double check these details before you open a PR

  • [x] PR does not match another non-stale PR currently opened
  • [x] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • [x] PR's base is the develop branch.
  • [x] Your icons are inside a folder as seen here
  • [x] SVG matches the standards laid out here
  • [x] A new object is added in the devicon.json file as seen here

This PR closes NONE

This PR closes #1355 #1356

Link to prove your SVG is correct and up-to-date.

https://hardhat.org/ https://hardhat.org/docs

knight-95 avatar Aug 21 '22 02:08 knight-95

env.MESSAGE

github-actions[bot] avatar Aug 23 '22 22:08 github-actions[bot]

env.MESSAGE

github-actions[bot] avatar Aug 23 '22 22:08 github-actions[bot]

env.MESSAGE

github-actions[bot] avatar Aug 23 '22 23:08 github-actions[bot]

@Snailedlt 128x128 will make the picture bit unsized sweat_smile, but it works fine...

Try resizing without stretching it. It doesn't have to stretch to fit, just needs to be centered and fit either vertically or horizontally.

I would try and resize the original icon again if I were you :)

Snailedlt avatar Aug 24 '22 06:08 Snailedlt

@Snailedlt Changed svg viewBox="0 0 128 128" According to standards given in documentation Also the icon now looks good :)

Nice, looks better now. Only thing missing is to resize so it fits horizontally and center it. You can use one of the recommended tools in the wiki to do that.

Oh and it would be great if you provided a plain icon where the eth logo is transparent and the rest of the icon is the same color :)

Snailedlt avatar Aug 24 '22 10:08 Snailedlt

env.MESSAGE

github-actions[bot] avatar Aug 24 '22 14:08 github-actions[bot]

By the way on the hardhat website there is a wordmark version of the logo: https://hardhat.org/_next/static/media/hardhat-logo-dark.484eb916.svg and / or https://hardhat.org/_next/static/media/hardhat-logo.5c5f687b.svg

BenSouchet avatar Sep 07 '22 12:09 BenSouchet

@knight-95 Can you add the wordmark icon suggested by @BenSouchet too? 💯

Snailedlt avatar Sep 11 '22 11:09 Snailedlt

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs: Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons: Imgur Images

Here are the colored versions: Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

github-actions[bot] avatar Sep 11 '22 11:09 github-actions[bot]

Superseeded by #1565

Snailedlt avatar Dec 10 '22 11:12 Snailedlt