devicons
Add alphabetical ordering of `devicon.json` to PR checklist
Double check these details before you open a PR
- [x] PR does not match another non-stale PR currently opened
Features
This PR closes NONE
It is however related to #1327
Notes
Maybe the new_icon.md PR template should add the checklist item too ?
@Snailedlt Yep its looks good to me.
And I agree with @kilian-paquier this file: https://github.com/devicons/devicon/blob/develop/.github/PULL_REQUEST_TEMPLATE/new_icon.md
could be also edited like: from
A new object is added in the devicon.json file as seen here
to
A new object is added in the devicon.json file at the correct alphabetic position as seen here
Maybe the new_icon.md PR template should add the checklist item too ?
I'm not sure exactly what you mean, could you elaborate? Perhaps an example of exactly what should be updated?
Maybe the new_icon.md PR template should add the checklist item too ?
I'm not sure exactly what you mean, could you elaborate? Perhaps an example of exactly what should be updated?
Hello, sorry, I meant updating this markdown PR template https://github.com/devicons/devicon/blob/master/.github/PULL_REQUEST_TEMPLATE/new_icon.md with a new check
@Panquesito7 @BenSouchet @kilian-paquier Implemented the suggested changes. Let me know if you find anything else
@Snailedlt In the Files Changed section I don't see the modification of the new_icon.md file, is it normal ?
@Snailedlt In the Files Changed section I don't see the modification of the new_icon.md file, is it normal ?
Yeah I noticed that too. Happened after the merging through the GitHub UI for some reason. I'll mark the PR as a draft until I fix it
Ready for review again!
I rebased on develop, and fixed the link to the updating devicon.json wiki page now.
@kilian-paquier @Panquesito7 @BenSouchet Please look through the changes again and review them, thanks! :)