devicon icon indicating copy to clipboard operation
devicon copied to clipboard

[FEATURE REQUEST] Add links to TOS where applicable

Open Snailedlt opened this issue 3 years ago • 5 comments

I have searched through the issues and didn't find my problem.

  • [X] Confirm

Problem

Some companies have TOS (Terms of Service) for their icons. It's important for users to know this before using the icons we provide, so that they don't get in trouble. Breaking the TOS could in worst case lead to financial loss and/or lawsuits for any company using devicon.

Possible Solution

Solution

To make it easier for users to find the TOS for a given Icon, we can be helpful and show them a link to it on the devicon.dev website

Benefits

Users can more easily find TOS, and make sure they don't break any of the icon providers rules.

Additional information

No response

Snailedlt avatar Jun 08 '22 14:06 Snailedlt

Hello @Snailedlt, in the devicon.json, what could be the best attribute name for this matter ?

  • terms_of_service
  • tos
  • termOfService
  • termofservice

Other ?

Do you think of anything we should add in addition to the TOS url if applicable ?

kilianpaquier avatar Jul 03 '22 16:07 kilianpaquier

Imo it should be camelCase and descriptive. So termsOfService sounds good!

Relevant SO answer to what casing standards are used in json: https://stackoverflow.com/a/19287394/12206312

Snailedlt avatar Jul 04 '22 18:07 Snailedlt

Imo it should be cameCase and descriptive. So termsOfService sounds good!

Relevant SO answer to what casing standards are used in json: https://stackoverflow.com/a/19287394/12206312

Ok, going on that base then, I was thinking on showing the link above the section Font version in a new section called Terms of Service (TOS), on the left side in the selectedIcon section.

kilianpaquier avatar Jul 04 '22 18:07 kilianpaquier

Hello @Snailedlt,

I've made a fast new section for the TOS, what could be improved (font-family, size, etc.) ? Is the place fine ?

image

kilianpaquier avatar Jul 12 '22 14:07 kilianpaquier

@kilian-paquier Looks fine to me.

I would put it at the bottom instead of the top though :)

Snailedlt avatar Jul 12 '22 22:07 Snailedlt

This seems like a good idea and totally needed. Are you still working on this, @kilian-paquier, or should we let someone else work on it?

Thanks. 🙂

Panquesito7 avatar Oct 11 '22 04:10 Panquesito7