DeviceKit icon indicating copy to clipboard operation
DeviceKit copied to clipboard

isSimulator for tvOS

Open luckychris opened this issue 6 years ago • 2 comments

isSimulator for Apple TV

Fixes #220

luckychris avatar Nov 21 '19 16:11 luckychris

3 Warnings
:warning: Plist changed, don’t forget to localize your plist values
:warning: Source/Device.generated.swift#L668 - Prefer non-optional booleans over optional booleans.
:warning: Source/Device.generated.swift#L1263 - Prefer empty collection over optional collection.

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 668 Prefer non-optional booleans over optional booleans.
Device.generated.swift 1263 Prefer empty collection over optional collection.

Generated by :no_entry_sign: Danger

devicekit-danger-bot avatar Nov 21 '19 16:11 devicekit-danger-bot

Can you make the isSimulator test available on tvOS too? https://github.com/luckychris/DeviceKit/blob/7a2ba7d34c19c45f0a5d55f3b6651f73e5e6c675/Tests/Tests.swift#L33

Zandor300 avatar Nov 29 '19 15:11 Zandor300

Closed in favour of https://github.com/devicekit/DeviceKit/pull/245

Zandor300 avatar Oct 31 '22 16:10 Zandor300