Add macos support #184

[phimage]

The commit allow to compile with SwiftPM and if necessary I can make a PR just for this one

The second one add models dumped from apple web site

There is some double when using "identifier" so I put the PR as WIP I do not know what to do. Merge into one. Find a way to make some alias with template generations

My very dirty dump script is available here https://github.com/phimage/MacModelDump

[devicekit-danger-bot]

	4 Warnings
:warning:	Big PR, consider splitting into smaller
:warning:	Plist changed, don’t forget to localize your plist values
:warning:	Source/Device.generated.swift#L995 - Prefer non-optional booleans over optional booleans.
:warning:	Source/Device.generated.swift#L1734 - Prefer empty collection over optional collection.

SwiftLint found issues

Warnings

File	Line	Reason
Device.generated.swift	995	Prefer non-optional booleans over optional booleans.
Device.generated.swift	1734	Prefer empty collection over optional collection.

Generated by :no_entry_sign: Danger

[phimage]

manually removed the double and old mac devices wip: removed

[Zandor300]

Next to the little thing a very nice addition!

[phimage]

Thanks for the review. I updated manually the iMacPro name

---

I make different output formats https://github.com/phimage/MacModelDump To output for DeviceKit launch macmodeldump devicekit

[phimage]

New macbook pro 16 inch 2019

https://support.apple.com/kb/SP809 https://www.apple.com/macbook-pro-16/ https://www.youtube.com/watch?v=ysRigNyavF4

but no model identifier yet! https://support.apple.com/en-us/HT201300

[Zandor300]

@phimage Sorry for late reply and inactivity. I found some formatting inconsistencies. Please fix those.

~Also, the device identifier is available now: MacBookPro16,1~ Edit: I see you already added that.

[phimage]

    case macPro2019

Mac Pro (2019)

With also some missing macPro that apple add to the its support page

[Kylmakalle]

Hey, any updates on this? Looks pretty useful.

[Kylmakalle]

@phimage @Zandor300 anything that blocks merge? 😄

[skeletom]

Hello, it is a really useful PR do you plan to merge it soon? Thank you!

[pfandrade]

Would also love to see this merged.

[vincentleclerc]

Why wasn't this merged...? No more discussion on it, and this is just stagnant.. very important feature for DeviceKit imo.

[AvdLee]

@Zandor300 would love to see this getting merged as well! 🙏

[phimage]

Hi, my Pull Request is very old, a lot of change happens on DeviceKit (see conflicts and new features) and I do not use it anymore (so I will no work on it)

If someone want macOS I think, first is to make a new Pull Request (and maybe be inspired by this one)

[Zandor300]

I do want to take a look at this still at some point, just need to find the time...

[codecov-commenter]

Codecov Report

Merging #217 (ecdfbb1) into master (f19f9f8) will not change coverage. The diff coverage is n/a.

@@      Coverage Diff      @@
##   master   #217   +/-   ##
=============================
=============================

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more