painterro
painterro copied to clipboard
[a11y]: Accept/Cancel buttons for Text tool do not have accessible names
Describe the bug
The "Accept" and "Cancel" buttons when adding text do not have accessible names.
In the accessibility tree:
You'll notice that the elements have a
title attribute, but no ARIA attributes.
Painterro version 1.2.87
To Reproduce Steps to reproduce the behavior:
- On the painterro canvas, select the "Text" tool
- Click anywhere to enter text
- Notice the "Accept" and "Cancel" buttons appear under the text box
- Right-click, inspect, and notice there are no ARIA attributes in the accessibility tree
Expected behavior The "Accept" and "Cancel" buttons for text entry should have accessible names.
Screenshots See above
Browser Chrome 122
Oh wow, thabks, did not know about it, feel free to add pull request with this aria stuff for all buttons, I will merge