painterro icon indicating copy to clipboard operation
painterro copied to clipboard

[a11y]: Accept/Cancel buttons for Text tool do not have accessible names

Open ozyx opened this issue 1 year ago • 1 comments

Describe the bug The "Accept" and "Cancel" buttons when adding text do not have accessible names. image

In the accessibility tree: image You'll notice that the elements have a title attribute, but no ARIA attributes.

Painterro version 1.2.87

To Reproduce Steps to reproduce the behavior:

  1. On the painterro canvas, select the "Text" tool
  2. Click anywhere to enter text
  3. Notice the "Accept" and "Cancel" buttons appear under the text box
  4. Right-click, inspect, and notice there are no ARIA attributes in the accessibility tree

Expected behavior The "Accept" and "Cancel" buttons for text entry should have accessible names.

Screenshots See above

Browser Chrome 122

ozyx avatar Mar 06 '24 18:03 ozyx

Oh wow, thabks, did not know about it, feel free to add pull request with this aria stuff for all buttons, I will merge

ivictbor avatar Mar 06 '24 21:03 ivictbor