Object-Goal-Navigation icon indicating copy to clipboard operation
Object-Goal-Navigation copied to clipboard

Potential inconsistency in metric and reward computation

Open srama2512 opened this issue 4 years ago • 0 comments

Why does starting_distance in ObjectGoal_Env includes the object_boundary distance? https://github.com/devendrachaplot/Object-Goal-Navigation/blob/5d76902fe9be821926a1de32557ca9a8dc21d0f5/envs/habitat/objectgoal_env.py#L143-L145

The shortest path should only reach the object boundary right? Not the object itself. This also propagates into the reward for action 0 since prev_distance includes the object boundary, but curr_distance does not. https://github.com/devendrachaplot/Object-Goal-Navigation/blob/5d76902fe9be821926a1de32557ca9a8dc21d0f5/envs/habitat/objectgoal_env.py#L395-L399

The object_boundary should be not be added to starting_distance. Happy to send a PR if this makes sense.

srama2512 avatar May 05 '21 16:05 srama2512