Jason Miller comments

Results 1202 comments of


                                            Jason Miller

Use customHistory url instead of internal url in render if available

@hesselbom how are you blocking the history change? Just trying to set up a demo.

Use customHistory url instead of internal url in render if available

oh wow, I didn't know `history.block` was even a thing!

Use customHistory url instead of internal url in render if available

Just circling back to this - shouldn't this handler be getting fired to take block() into account? https://github.com/developit/preact-router/pull/140/files#diff-1fdf421c05c1140f6d71444ea2b27638R193

How to override router on select anchors

You can add a `native` attribute to links to bypass preact-router's internal handling of them: ```html click me to perform a full navigation ```

activeClassName won't work if Link's href has a search

Ah good call. What would the most predictable behavior be here? Also I think there's an option to specify the match URL manually: ```js Book ``` (not sure if that...

Not able to build on Windows

Looking to switch to jsdom + node for the tests (likely via Jest) to fix this.

Not able to build on Windows

There's a module called `cross-var` that can help with that

Not able to build on Windows

I'm not big on them. Rollup already supports 90% of what is needed here - for example, it can output gzipped bundle size. I'm just not using it properly :P

Problems with link anchors

Hmm - no need for custom code here really - you can use the `native` prop to bypass preact-router for any link, including anchors. It'll just use the browser's default...

Problems with link anchors

Ah, I didn't realize that would fire popstate. Perhaps changing `Router`'s routing logic ignore the URL hash would fix this since the `routeTo()` would be a no-op?