opensource icon indicating copy to clipboard operation
opensource copied to clipboard

Enforce code style with prettier and eslint.

Open david-mateogit opened this issue 5 years ago • 3 comments

Hello.

I would like to test this project and later contribute if needed but I think this needs a prettier or eslint config to enforce the recommended code-style.

This worked on my build at the end of package.json, have to do more tests.

"prettier": { "printWidth": 120, "tabWidth": 1, "singleQuote": true, "trailingComma": "none", "semi": false }, "eslintConfig": { "parserOptions": { "ecmaVersion": 8, "sourceType": "module" }, "rules": { "semi": ["error", "never"] } }

I think some system like this would provide consistency and less headaches when people save and have auto format on vs code and such.

What do you think?

david-mateogit avatar Apr 03 '20 13:04 david-mateogit

Sounds good to me

On Fri, Apr 3, 2020, 09:57 David Mateo [email protected] wrote:

Hello.

I would like to test this project and later contribute if needed but I think this needs a prettier or eslint config to enforce the recommended code-style.

This worked on my build at the end of package.json, have to do more tests.

"prettier": { "printWidth": 120, "tabWidth": 1, "singleQuote": true, "trailingComma": "none", "semi": false }, "eslintConfig": { "parserOptions": { "ecmaVersion": 8, "sourceType": "module" }, "rules": { "semi": ["error", "never"] } }

I think some system like this would provide consistency and less headaches when people save and have auto format on vs code and such.

What do you think?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/developersdo/opensource/issues/136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADLMH3QGPRGDSVMHPXMNIDRKXTOLANCNFSM4L4BODBA .

rmariuzzo avatar Apr 03 '20 15:04 rmariuzzo

Hey @rmariuzzo could you please check this PR https://github.com/developersdo/opensource/pull/133?

DannyFeliz avatar Apr 03 '20 15:04 DannyFeliz

Sounds good to me …

Great. I'll do some tests and send a pr later.

BTW as a DR Dev I thank you for this.

david-mateogit avatar Apr 03 '20 17:04 david-mateogit