react-hls icon indicating copy to clipboard operation
react-hls copied to clipboard

Support react 17 as peerDependency

Open clumsyjedi opened this issue 3 years ago • 1 comments

As per https://github.com/devcshort/react-hls/issues/34 peerDependency errors are emitted when using this module with react 17. This change should suppress these errors, we have tested it using a sample video.

Users are welcome to use a deployed artifact of @panelist/react-hls-player until this is merged / #34 is resolved.

clumsyjedi avatar Feb 17 '22 23:02 clumsyjedi

I don't think this is really a fix, you're just removing the dependency check instead of actually refactoring whatever code that relies on React 16. I'm having issues with playerRef when forcing it to use React 17.

soheil avatar Mar 24 '22 12:03 soheil