devcontainers
feat: add tools_path variable to kubectl-helm-minikube feature
Some tools and extensions expect to find the tools in a particular PATH that is not /usr/local/bin
@microsoft-github-policy-service agree
On May 25, 2024, at 2:27 PM, microsoft-github-policy-service[bot] @.***> wrote:
@robinmordasiewicz https://github.com/robinmordasiewicz please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"] Options:
(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer. @microsoft-github-policy-service agree (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer. @microsoft-github-policy-service agree company="Microsoft" Contributor License Agreement http://www.opensource.org/ — Reply to this email directly, view it on GitHub https://github.com/devcontainers/features/pull/981#issuecomment-2131385112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG2O2ODYCPYSK653TEYCCDTZEDJXZAVCNFSM6AAAAABIJCZZRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZRGM4DKMJRGI. You are receiving this because you were mentioned.
I do not know how to add tests yet.
On Jun 4, 2024, at 2:37 PM, Samruddhi Khandale @.***> wrote:
@samruddhikhandale commented on this pull request.
In src/kubectl-helm-minikube/install.sh https://github.com/devcontainers/features/pull/981#discussion_r1626456744:
@@ -15,6 +15,7 @@ rm -rf /var/lib/apt/lists/* KUBECTL_VERSION="${VERSION:-"latest"}" HELM_VERSION="${HELM:-"latest"}" MINIKUBE_VERSION="${MINIKUBE:-"latest"}" # latest is also valid +TOOLS_PATH="${TOOLS_PATH:-"/usr/local/bin"}" # latest is also valid Can we add some tests to validate this change?
— Reply to this email directly, view it on GitHub https://github.com/devcontainers/features/pull/981#discussion_r1626456744, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG2O2OCTGQY7LEBHLH4MYT3ZFYCPFAVCNFSM6AAAAABIJCZZRKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOJXGE2DIMZUG4. You are receiving this because you were mentioned.