features icon indicating copy to clipboard operation
features copied to clipboard

DinD and DoutD does not support Alpine Base Images

Open sr229 opened this issue 2 years ago • 5 comments

Official devcontainer features should be at least be able to support their own base images, however, in the case for Docker in Docker and Docker outside Docker, and a couple of few more features, they do not support the Alpine image.

sr229 avatar Nov 13 '23 11:11 sr229

Thanks for the feedback. I agree that would be ideal. With the engineering capacity we have on the maintainers team, we're only able to officially support a subset of what we'd like to - in this case it's that our Features are compatible with debian-like distros. Features like common-utils we maintain for multiple distros due to its convenience.

I'd encourage members of the community that would find this useful to build their own Features and share them with the community (and post here for visibility if folks search in the future!).

joshspicer avatar Nov 13 '23 18:11 joshspicer

+1 to Josh's comment above.

Also, if you are interested, feel free to contribute a PR for docker-in-docker and docker-outside-of-docker Features with added support for Alpine. We'd appreciate that, and happy to help in the process. Thank you!

samruddhikhandale avatar Nov 14 '23 21:11 samruddhikhandale

I'd love to see the official features (and templates) support Alpine.

I've created local-features that are specific to Alpine, but follow the patterns set in this repository. I borrowed the idea from the kubernetes-helm template.

Most of my work was done to simplify the installation of Kubernetes based tools for other developers. While reproducing the functionality of the existing features and templates (and creating some of my own), I found that writing installation shell scripts for Alpine can be significantly different than writing them for Debian (the preferred distro for this repository.) This is primarily due how apk works compared to apt and deb.

Two questions:

  • We currently have the install.sh file.
    • Would it be better to have two additional files, one for Debian and another for Alpine?
    • In this case, install.sh would determine which of the installation to call based on the test in common-utils.sh.
  • Could the Alpine versions of DinD and DoutD use the package manager?
    • Does Alpine need the option to use Moby vs the package manager?

Thanks

robv8r avatar Nov 26 '23 20:11 robv8r

i've created a list of alpine features maybe it could help

cirolosapio avatar Apr 23 '24 22:04 cirolosapio

+1 to Josh's comment above.

Also, if you are interested, feel free to contribute a PR for docker-in-docker and docker-outside-of-docker Features with added support for Alpine. We'd appreciate that, and happy to help in the process. Thank you!

I'd be happy to help if you can guide me to the right direction, I'll give it a gander and see what I can fix!

sr229 avatar Apr 25 '24 06:04 sr229